Ramsundar - Frontend Fix "Usage Record" modal not displaying Data#4455
Ramsundar - Frontend Fix "Usage Record" modal not displaying Data#4455Ram-blip wants to merge 1 commit intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
VijayAnirudh
left a comment
VijayAnirudh
left a comment
There was a problem hiding this comment.
Review Summary ✅
Tested the Frontend_Fix_Usage_Record_Modal_Not_Displaying_Data branch locally:
-
Modal Behavior
- Clicking View under the Usage Record column now correctly opens the modal with data populated.
- When no records exist, a proper empty state message is displayed instead of a blank modal.
-
Integration
- Verified frontend fix works in conjunction with backend PR #1921.
- Email field is included and displays correctly in usage records.
-
Testing Steps
- Cleared site data/cache, logged in as admin.
- Navigated to
/bmdashboard/consumables. - Confirmed modal renders data and empty state as expected.
-
Quality Checks
- No console errors or warnings observed.
- Netlify deploy preview matches local behavior.
- SonarQube Quality Gate passed (0 issues).
Conclusion
All acceptance criteria have been met:
- Modal displays usage record data correctly.
- Empty state message works as intended.
- Integration with backend fix confirmed.
Approving this PR ✅
There was a problem hiding this comment.
[Edit]
I've tested the PR again.
- I can see the emails
- Every "view" option (user record, update record, purchase record) works fine!
- But in dark mode I cannot see the column headings.
- Please correct the naming "UsageRecord Record" --> "Usage Record."
Great work! Please fix the dark mode.
|
I checked the latest dev website and it looks like someone has worked on it. Last time the page was connected to a different endpoint. I think someone created a new endpoint and changed the UI, so everything is different now. So, I am closing this PR. |
2 participants
Description
Related PRS (if any):
This frontend PR is related to the #1921 backend PR.
Main changes explained:
How to test:
npm installand npm run start:local to run this PR locallyScreenshots or videos of changes:
https://www.loom.com/share/398669df8e984df28cbd3dd5f919b856
Note:
Include the information the reviewers need to know.